python-stdlib/enum/enum.py: Add Enum class.#980
python-stdlib/enum/enum.py: Add Enum class.#980IhorNehrutsa wants to merge 3 commits intomicropython:masterfrom
Conversation
Signed-off-by: Ihor Nehrutsa <Ihor.Nehrutsa@gmail.com>
|
Usage example:: Output is:: |
|
Thanks for the contribution, this looks pretty good! Did you implement this from scratch, or copy parts from CPython's implementation? I'm just wondering about licensing and copyright. Can you please add the test to the CI, in |
I just saw CPython Enum. It looks like incredible magic. :-) |
Signed-off-by: Ihor Nehrutsa <Ihor.Nehrutsa@gmail.com>
That doesn't really answer the question. Did you copy this implementation from CPython? Also, please make sure the CI all passes, there's currently a failure. |
|
| Did you implement this from scratch, or copy parts from CPython's implementation? No, I didn't use CPython implementation. It was inspired by @shariltumin Dot class from the Way to use dot notation to refer to states in a state machine #15694 |
Signed-off-by: Ihor Nehrutsa <Ihor.Nehrutsa@gmail.com>
|
Should I squash commits? |
| @@ -0,0 +1,91 @@ | |||
| # enum_test.py | |||
|
|
|||
| from enum import Enum, enum | |||
There was a problem hiding this comment.
I tried to run this test under CPython 3.12.2 but it doesn't work, for many reasons. And it should run under CPython so we can test that the implementation of MicroPython's enum matches the CPython enum.
For example, enum does not exist in the enum CPython module. Which version of CPython were you testing against?
| Enabled = True | ||
|
|
||
|
|
||
| state = Enum() |
There was a problem hiding this comment.
CPython cannot create enums in this way.
|
|
||
| state = Enum() | ||
| print(state) | ||
| state = Direction() |
There was a problem hiding this comment.
CPython requires a value in the constructor here.
| print(state) | ||
| state = State() | ||
| print(state) | ||
| state = State({"X": 1.0, "Y": 2.0}) |
There was a problem hiding this comment.
CPython doesn't allow such an argument to the constructor.
|
|
||
| print("Direction(Direction.CCW):", Direction(Direction.CCW)) | ||
| print("Direction('CW'):", Direction("CW")) | ||
| print("state(10):", state(10)) |
There was a problem hiding this comment.
CPython doesn't allow calling an enum.
| print("state('CW'):", state("CW")) | ||
| print("type(state('CW')):", type(state("CW"))) | ||
|
|
||
| print("state.key_from_value(20):", state.key_from_value(20)) |
There was a problem hiding this comment.
CPython doesn't have key_from_value().
| CCW = "CCW" | ||
|
|
||
|
|
||
| class State(Direction): |
There was a problem hiding this comment.
CPython doesn't allow inheriting enums from each other.
| print("type(state('CW')):", type(state("CW"))) | ||
|
|
||
| print("state.key_from_value(20):", state.key_from_value(20)) | ||
| print("len(state):", len(state)) |
There was a problem hiding this comment.
CPython doesn't have __len__ on an enum.
|
|
||
| print("state.keys():", state.keys()) | ||
| print("state.values():", state.values()) | ||
| print("state.items():", state.items()) |
There was a problem hiding this comment.
CPython enums don't have keys/values/items methods.
|
There is a quite comprehensive set of unit-tests for enum available in CPython: https://github.com/python/cpython/blob/main/Lib/test/test_enum.py |
|
I have successfully completed the task that requires the Enum class. |
Docs in:
docs/library/enum.rst: Add Enum class. #16842
Usage example:
Output is:
EDITED:
Inspired by @shariltumin Dot class from the Way to use dot notation to refer to states in a state machine #15694
and @njourdane enum() func from the Request for package: micropython-enum #269